Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backports-release-1.11] Actually setup jit targets when compiling packageimages instead of targeting only one (#54471) #56239

Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 18, 2024

Specific backport for #54471 for consideration given #54471 (comment)

Would fix #56177 according to @giordano

@giordano
Copy link
Contributor

To show that this does fix #56177:

$ julia +pr56239 -E 'Base.current_image_targets()'
Base.ImageTarget[znver4; flags=0; features_en=(sse3, pclmul, ssse3, fma, cx16, sse4.1, sse4.2, movbe, popcnt, aes, xsave, avx, f16c, fsgsbase, bmi, avx2, bmi2, avx512f, avx512dq, adx, avx512ifma, clflushopt, clwb, avx512cd, sha, avx512bw, avx512vl, avx512vbmi, pku, avx512vbmi2, shstk, gfni, vaes, vpclmulqdq, avx512vnni, avx512bitalg, avx512vpopcntdq, rdpid, sahf, lzcnt, sse4a, prfchw, mwaitx, xsavec, xsaves, clzero, wbnoinvd, avx512bf16)]

avx512 features are there, unlike in #56177 (comment) with julia v1.11.1.

I still don't have an answer to why this change resolves the issue, but setting up the JIT targets correctly is good anyway, since it was broken in previous versions.

@giordano
Copy link
Contributor

@Vobarkun can you please test that this fully solves the issue for you? I could only check the avx512 features, I don't think I have currently access to a heterogeneous system where I can replicate your issue, but if the problem you had was basically due to the wrong features detection (which would explain why the incompatible pkgimage wasn't rejected) then we should be good.

@Vobarkun
Copy link

Yes, this appears to fix it. The features are now detected correctly also for me and the cache file gets properly rejected.

@maleadt maleadt merged commit ff4549d into JuliaLang:backports-release-1.11 Oct 21, 2024
6 checks passed
@IanButterworth IanButterworth deleted the ib/backport_targets branch October 21, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants